Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/app_modal_strings.grdp ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_frame_test_proxy.h
diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h
index 363f5e3794ec16e9fa2b2b9c532d139f5ce06d40..1cbe11f80ef6c58c6c714f658997e1a3524bb30e 100644
--- a/components/test_runner/web_frame_test_proxy.h
+++ b/components/test_runner/web_frame_test_proxy.h
@@ -167,10 +167,9 @@ class WebFrameTestProxy : public Base {
return true;
}
- bool runModalBeforeUnloadDialog(bool is_reload,
- const blink::WebString& message) override {
+ bool runModalBeforeUnloadDialog(bool is_reload) override {
base_proxy_->GetDelegate()->PrintMessage(
- std::string("CONFIRM NAVIGATION: ") + message.utf8().data() + "\n");
+ std::string("CONFIRM NAVIGATION\n"));
return !base_proxy_->GetInterfaces()
->TestRunner()
->ShouldStayOnPageAfterHandlingBeforeUnload();
« no previous file with comments | « components/app_modal_strings.grdp ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698