Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org

Committed: https://crrev.com/33c282f0e299b711f0f18f1222ead28a7623cbbd
Cr-Commit-Position: refs/heads/master@{#370672}

[Olli Raula, 2016-01-18 09:56:04]

Description was changed from

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead referenced size_t
parameter. Logic inside is untouched.
==========

to

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead referenced size_t
parameter. Logic inside is untouched.
==========

[Olli Raula, 2016-01-18 09:56:04]

olli.raula@intel.com changed reviewers:
+ mmenke@chromium.org

[Olli Raula, 2016-01-18 09:56:44]

Could you review? I think we can tbr everything else than net/ ?

[mmenke, 2016-01-19 22:32:24]

https://codereview.chromium.org/1594973004/diff/1/net/http/http_response_head...
File net/http/http_response_headers.h (right):

https://codereview.chromium.org/1594973004/diff/1/net/http/http_response_head...
net/http/http_response_headers.h:169: bool EnumerateHeaderLines(size_t& i,
Passing by non-const reference is forbidden.  Use size_t*.

https://codereview.chromium.org/1594973004/diff/1/net/http/http_response_head...
net/http/http_response_headers.h:169: bool EnumerateHeaderLines(size_t& i,
Also, "i" isn't meaningful name.  Maybe just "index", though that may expose too
much to consumers, and encourage incorrect usage.  Could just stick with iter.

https://codereview.chromium.org/1594973004/diff/1/net/http/http_response_head...
net/http/http_response_headers.h:179: bool EnumerateHeader(void** iter,
I assume you intend to change this one as well, in a followup CL?  That's fine,
just making sure we won't be stuck with doing different things on functions that
work the same way in the same file for too long.

[Olli Raula, 2016-01-20 13:40:35]

Description was changed from

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead referenced size_t
parameter. Logic inside is untouched.
==========

to

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.
==========

[Olli Raula, 2016-01-20 13:42:52]

Thanks, fixed. That another one is coming, hopefully this week.

[mmenke, 2016-01-20 16:01:18]

On 2016/01/20 13:42:52, Olli Raula wrote:
> Thanks, fixed. That another one is coming, hopefully this week.

LGTM!

And yes, I think it's fine to TBR this CL.  I'm not sure if you're not a full
committer - if not, I may have to press the CQ button after you add the TBR
lines.

[Olli Raula, 2016-01-21 11:01:05]

Description was changed from

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.
==========

to

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org
==========

[Olli Raula, 2016-01-21 11:01:21]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2016-01-21 11:02:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594973004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594973004/20001

[commit-bot: I haz the power, 2016-01-21 12:13:01]

Description was changed from

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org
==========

to

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org
==========

[commit-bot: I haz the power, 2016-01-21 12:13:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 12:13:55]

Description was changed from

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org
==========

to

==========
Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org

Committed: https://crrev.com/33c282f0e299b711f0f18f1222ead28a7623cbbd
Cr-Commit-Position: refs/heads/master@{#370672}
==========

[commit-bot: I haz the power, 2016-01-21 12:13:57]

Patchset 2 (id:??) landed as
https://crrev.com/33c282f0e299b711f0f18f1222ead28a7623cbbd
Cr-Commit-Position: refs/heads/master@{#370672}