content/browser/appcache/appcache_internals_ui.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_internals_ui.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | content/browser/devtools/devtools_netlog_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_internals_ui.cc

diff --git a/content/browser/appcache/appcache_internals_ui.cc b/content/browser/appcache/appcache_internals_ui.cc

index 3abd692603a20cd68bfbf170b4cdb8330e803722..0c402129b60e4b2a35bcec7ea67ff7a2e1f15b2c 100644

--- a/content/browser/appcache/appcache_internals_ui.cc

+++ b/content/browser/appcache/appcache_internals_ui.cc

@@ -462,7 +462,7 @@ void AppCacheInternalsUI::OnFileDetailsReady(

response_info->http_response_info()->headers->GetStatusLine()));

headers.push_back('\n');

- void* iter = nullptr;

+ size_t iter = 0;

std::string name, value;

while (response_info->http_response_info()->headers->EnumerateHeaderLines(

&iter, &name, &value)) {

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | content/browser/devtools/devtools_netlog_observer.cc » ('j') | no next file with comments »