chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/streams_private/streams_private_api.cc ('k') | chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 3b672fe27e44a271e43eba1e0be2519b95d61505..fb391c1c23449c6e178d0bf3dd4c5c592786b454 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -2090,7 +2090,7 @@ TEST(ExtensionWebRequestHelpersTest, TestMergeOnHeadersReceivedResponses) {

EXPECT_TRUE(allowed_unsafe_redirect_url1.is_empty());

std::multimap<std::string, std::string> expected1;

expected1.insert(std::pair<std::string, std::string>("Key2", "Value3"));

- void* iter = NULL;

+ size_t iter = 0;

std::string name;

std::string value;

std::multimap<std::string, std::string> actual1;

@@ -2122,7 +2122,7 @@ TEST(ExtensionWebRequestHelpersTest, TestMergeOnHeadersReceivedResponses) {

&net_log);

ASSERT_TRUE(new_headers2.get());

EXPECT_TRUE(allowed_unsafe_redirect_url2.is_empty());

- iter = NULL;

+ iter = 0;

std::multimap<std::string, std::string> actual2;

while (new_headers2->EnumerateHeaderLines(&iter, &name, &value)) {

actual2.insert(std::pair<std::string, std::string>(name, value));

@@ -2172,7 +2172,7 @@ TEST(ExtensionWebRequestHelpersTest,

expected1.insert(std::pair<std::string, std::string>("Key1", "Value1"));

expected1.insert(std::pair<std::string, std::string>("Key1", "Value3"));

expected1.insert(std::pair<std::string, std::string>("Key2", "Value4"));

- void* iter = NULL;

+ size_t iter = 0;

std::string name;

std::string value;

std::multimap<std::string, std::string> actual1;