components/cronet/android/chromium_url_request.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/chromium_url_request.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/threat_details_cache.cc ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/chromium_url_request.cc

diff --git a/components/cronet/android/chromium_url_request.cc b/components/cronet/android/chromium_url_request.cc

index 2e824091a554f88f2f07d2d63798a2dfa3d00dbd..6f047e6a680efb9398947f09d667cfa050863677 100644

--- a/components/cronet/android/chromium_url_request.cc

+++ b/components/cronet/android/chromium_url_request.cc

@@ -376,7 +376,7 @@ static void GetAllHeaders(JNIEnv* env,

if (headers == NULL)

return;

- void* iter = NULL;

+ size_t iter = 0;

std::string header_name;

std::string header_value;

while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {

« no previous file with comments | « chrome/browser/safe_browsing/threat_details_cache.cc ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »