Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: net/http/http_response_headers.h

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/network/url_loader_impl.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index 91c223ebe8153a0a811af7cee9b93a87fe489010..7d75c63e5ef6bad4c06d213d0c230a32dec79ee3 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -163,10 +163,10 @@ class NET_EXPORT HttpResponseHeaders
// header appears on multiple lines, then it will appear multiple times in
// this enumeration (in the order the header lines were received from the
// server). Also, a given header might have an empty value. Initialize a
- // 'void*' variable to NULL and pass it by address to EnumerateHeaderLines.
+ // 'size_t' variable to 0 and pass it by address to EnumerateHeaderLines.
// Call EnumerateHeaderLines repeatedly until it returns false. The
// out-params 'name' and 'value' are set upon success.
- bool EnumerateHeaderLines(void** iter,
+ bool EnumerateHeaderLines(size_t* iter,
std::string* name,
std::string* value) const;
@@ -176,6 +176,7 @@ class NET_EXPORT HttpResponseHeaders
// initialize a 'void*' variable to NULL and pass it by address to
// EnumerateHeader. Note that a header might have an empty value. Call
// EnumerateHeader repeatedly until it returns false.
+ // TODO(Olli Raula) Remove void**
bool EnumerateHeader(void** iter,
const base::StringPiece& name,
std::string* value) const;
« no previous file with comments | « mojo/services/network/url_loader_impl.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698