Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: ios/web/public/test/response_providers/data_response_provider.mm

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/net/protocol_handler_util.mm ('k') | mojo/services/network/url_loader_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/web/public/test/response_providers/data_response_provider.h" 5 #include "ios/web/public/test/response_providers/data_response_provider.h"
6 6
7 #include "base/strings/sys_string_conversions.h" 7 #include "base/strings/sys_string_conversions.h"
8 #import "ios/third_party/gcdwebserver/src/GCDWebServer/Responses/GCDWebServerDat aResponse.h" 8 #import "ios/third_party/gcdwebserver/src/GCDWebServer/Responses/GCDWebServerDat aResponse.h"
9 9
10 namespace web { 10 namespace web {
11 11
12 GCDWebServerResponse* DataResponseProvider::GetGCDWebServerResponse( 12 GCDWebServerResponse* DataResponseProvider::GetGCDWebServerResponse(
13 const Request& request) { 13 const Request& request) {
14 std::string response_body; 14 std::string response_body;
15 scoped_refptr<net::HttpResponseHeaders> response_headers; 15 scoped_refptr<net::HttpResponseHeaders> response_headers;
16 GetResponseHeadersAndBody(request, &response_headers, &response_body); 16 GetResponseHeadersAndBody(request, &response_headers, &response_body);
17 GCDWebServerDataResponse* data_response = [GCDWebServerDataResponse 17 GCDWebServerDataResponse* data_response = [GCDWebServerDataResponse
18 responseWithHTML:base::SysUTF8ToNSString(response_body)]; 18 responseWithHTML:base::SysUTF8ToNSString(response_body)];
19 data_response.statusCode = response_headers->response_code(); 19 data_response.statusCode = response_headers->response_code();
20 void* iter = nullptr; 20 size_t iter = 0;
21 std::string name; 21 std::string name;
22 std::string value; 22 std::string value;
23 while (response_headers->EnumerateHeaderLines(&iter, &name, &value)) { 23 while (response_headers->EnumerateHeaderLines(&iter, &name, &value)) {
24 // TODO(crbug.com/435350): Extract out other names that can't be set by 24 // TODO(crbug.com/435350): Extract out other names that can't be set by
25 // using the |setValue:forAdditionalHeader:| API such as "ETag" etc. 25 // using the |setValue:forAdditionalHeader:| API such as "ETag" etc.
26 if (name == "Content-type") { 26 if (name == "Content-type") {
27 data_response.contentType = base::SysUTF8ToNSString(value); 27 data_response.contentType = base::SysUTF8ToNSString(value);
28 continue; 28 continue;
29 } 29 }
30 [data_response setValue:base::SysUTF8ToNSString(value) 30 [data_response setValue:base::SysUTF8ToNSString(value)
31 forAdditionalHeader:base::SysUTF8ToNSString(name)]; 31 forAdditionalHeader:base::SysUTF8ToNSString(name)];
32 } 32 }
33 return data_response; 33 return data_response;
34 } 34 }
35 35
36 } // namespace web 36 } // namespace web
OLDNEW
« no previous file with comments | « ios/net/protocol_handler_util.mm ('k') | mojo/services/network/url_loader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698