Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/safe_browsing/threat_details_cache.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Implementation of the ThreatDetails class. 5 // Implementation of the ThreatDetails class.
6 6
7 #include "chrome/browser/safe_browsing/threat_details.h" 7 #include "chrome/browser/safe_browsing/threat_details.h"
8 8
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 DCHECK_CURRENTLY_ON(BrowserThread::IO); 144 DCHECK_CURRENTLY_ON(BrowserThread::IO);
145 net::HttpResponseHeaders* headers = source->GetResponseHeaders(); 145 net::HttpResponseHeaders* headers = source->GetResponseHeaders();
146 if (!headers) { 146 if (!headers) {
147 DVLOG(1) << "Missing response headers."; 147 DVLOG(1) << "Missing response headers.";
148 return; 148 return;
149 } 149 }
150 150
151 ClientSafeBrowsingReportRequest::HTTPResponse* pb_response = 151 ClientSafeBrowsingReportRequest::HTTPResponse* pb_response =
152 pb_resource->mutable_response(); 152 pb_resource->mutable_response();
153 pb_response->mutable_firstline()->set_code(headers->response_code()); 153 pb_response->mutable_firstline()->set_code(headers->response_code());
154 void* iter = NULL; 154 size_t iter = 0;
155 std::string name, value; 155 std::string name, value;
156 while (headers->EnumerateHeaderLines(&iter, &name, &value)) { 156 while (headers->EnumerateHeaderLines(&iter, &name, &value)) {
157 ClientSafeBrowsingReportRequest::HTTPHeader* pb_header = 157 ClientSafeBrowsingReportRequest::HTTPHeader* pb_header =
158 pb_response->add_headers(); 158 pb_response->add_headers();
159 pb_header->set_name(name); 159 pb_header->set_name(name);
160 // Strip any Set-Cookie headers. 160 // Strip any Set-Cookie headers.
161 if (base::LowerCaseEqualsASCII(name, "set-cookie")) { 161 if (base::LowerCaseEqualsASCII(name, "set-cookie")) {
162 pb_header->set_value(""); 162 pb_header->set_value("");
163 } else { 163 } else {
164 pb_header->set_value(value); 164 pb_header->set_value(value);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 199
200 void ThreatDetailsCacheCollector::AllDone(bool success) { 200 void ThreatDetailsCacheCollector::AllDone(bool success) {
201 DVLOG(1) << "AllDone"; 201 DVLOG(1) << "AllDone";
202 DCHECK_CURRENTLY_ON(BrowserThread::IO); 202 DCHECK_CURRENTLY_ON(BrowserThread::IO);
203 *result_ = success; 203 *result_ = success;
204 BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_); 204 BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
205 callback_.Reset(); 205 callback_.Reset();
206 } 206 }
207 207
208 } // namespace safe_browsing 208 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc ('k') | components/cronet/android/chromium_url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698