ios/web/public/test/response_providers/data_response_provider.mm - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/test/response_providers/data_response_provider.mm

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/public/test/response_providers/data_response_provider.mm

diff --git a/ios/web/public/test/response_providers/data_response_provider.mm b/ios/web/public/test/response_providers/data_response_provider.mm

index a109dbee133bea2cc8c7197b8a9b05a1b89bdfcf..4b1cd800ec61ef31b8734e05ef15b98b4fbd8e95 100644

--- a/ios/web/public/test/response_providers/data_response_provider.mm

+++ b/ios/web/public/test/response_providers/data_response_provider.mm

@@ -17,7 +17,7 @@ GCDWebServerResponse* DataResponseProvider::GetGCDWebServerResponse(

GCDWebServerDataResponse* data_response = [GCDWebServerDataResponse

responseWithHTML:base::SysUTF8ToNSString(response_body)];

data_response.statusCode = response_headers->response_code();

- void* iter = nullptr;

+ size_t iter = 0;

std::string name;

std::string value;

while (response_headers->EnumerateHeaderLines(&iter, &name, &value)) {

« no previous file with comments | « ios/net/protocol_handler_util.mm ('k') | mojo/services/network/url_loader_impl.cc » ('j') | no next file with comments »