Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: net/http/http_response_headers.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_response_headers.h ('k') | net/http/http_response_headers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.cc
diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc
index ba51cfdbc57355325c2e2224ffb2eed1a41cb745..7cf2d0c66ef8795b47181f59be429c662de53b28 100644
--- a/net/http/http_response_headers.cc
+++ b/net/http/http_response_headers.cc
@@ -313,7 +313,7 @@ void HttpResponseHeaders::RemoveHeaderLine(const std::string& name,
new_raw_headers.reserve(raw_headers_.size());
- void* iter = NULL;
+ size_t iter = 0;
std::string old_header_name;
std::string old_header_value;
while (EnumerateHeaderLines(&iter, &old_header_name, &old_header_value)) {
@@ -549,10 +549,10 @@ std::string HttpResponseHeaders::GetStatusText() const {
return std::string(begin, end);
}
-bool HttpResponseHeaders::EnumerateHeaderLines(void** iter,
+bool HttpResponseHeaders::EnumerateHeaderLines(size_t* iter,
std::string* name,
std::string* value) const {
- size_t i = reinterpret_cast<size_t>(*iter);
+ size_t i = *iter;
if (i == parsed_.size())
return false;
@@ -567,7 +567,7 @@ bool HttpResponseHeaders::EnumerateHeaderLines(void** iter,
value->assign(value_begin, value_end);
- *iter = reinterpret_cast<void*>(i);
+ *iter = i;
return true;
}
@@ -1394,7 +1394,7 @@ scoped_ptr<base::Value> HttpResponseHeaders::NetLogCallback(
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
base::ListValue* headers = new base::ListValue();
headers->Append(new base::StringValue(GetStatusLine()));
- void* iterator = NULL;
+ size_t iterator = 0;
std::string name;
std::string value;
while (EnumerateHeaderLines(&iterator, &name, &value)) {
« no previous file with comments | « net/http/http_response_headers.h ('k') | net/http/http_response_headers_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698