Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

net/http/http_response_headers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_RESPONSE_HEADERS_H_
 #define NET_HTTP_HTTP_RESPONSE_HEADERS_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 145 matching lines @@
 
   // Get the HTTP status text of the normalized status line.
   std::string GetStatusText() const;
 
   // Enumerate the "lines" of the response headers.  This skips over the status
   // line.  Use GetStatusLine if you are interested in that.  Note that this
   // method returns the un-coalesced response header lines, so if a response
   // header appears on multiple lines, then it will appear multiple times in
   // this enumeration (in the order the header lines were received from the
   // server).  Also, a given header might have an empty value.  Initialize a
-  // 'void*' variable to NULL and pass it by address to EnumerateHeaderLines.
+  // 'size_t' variable to 0 and pass it by address to EnumerateHeaderLines.
   // Call EnumerateHeaderLines repeatedly until it returns false.  The
   // out-params 'name' and 'value' are set upon success.
-  bool EnumerateHeaderLines(void** iter,
+  bool EnumerateHeaderLines(size_t& i,

[mmenke, 2016/01/19 22:32:24]

Also, "i" isn't meaningful name.  Maybe just "index", though that may expose too
much to consumers, and encourage incorrect usage.  Could just stick with iter.

[mmenke, 2016/01/19 22:32:24]

Passing by non-const reference is forbidden.  Use size_t*.

                             std::string* name,
                             std::string* value) const;
 
   // Enumerate the values of the specified header.   If you are only interested
   // in the first header, then you can pass NULL for the 'iter' parameter.
   // Otherwise, to iterate across all values for the specified header,
   // initialize a 'void*' variable to NULL and pass it by address to
   // EnumerateHeader. Note that a header might have an empty value. Call
   // EnumerateHeader repeatedly until it returns false.
   bool EnumerateHeader(void** iter,

[mmenke, 2016/01/19 22:32:24]

I assume you intend to change this one as well, in a followup CL?  That's fine,
just making sure we won't be stuck with doing different things on functions that
work the same way in the same file for too long.

                        const base::StringPiece& name,
                        std::string* value) const;
 
   // Returns true if the response contains the specified header-value pair.
   // Both name and value are compared case insensitively.
   bool HasHeaderValue(const base::StringPiece& name,
                       const base::StringPiece& value) const;
 
   // Returns true if the response contains the specified header.
   // The name is compared case insensitively.
@@ skipping 211 matching lines @@
 
   // The normalized http version (consistent with what GetStatusLine() returns).
   HttpVersion http_version_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpResponseHeaders);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_RESPONSE_HEADERS_H_