net/http/http_response_headers_unittest.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers_unittest.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_response_headers_unittest.cc

diff --git a/net/http/http_response_headers_unittest.cc b/net/http/http_response_headers_unittest.cc

index 1bc99bbd7b8717516bae7346dc5b03a0d43dcea2..9c58807392a2bb4ae63e9e49c63a3a7903a4634c 100644

--- a/net/http/http_response_headers_unittest.cc

+++ b/net/http/http_response_headers_unittest.cc

@@ -1055,7 +1055,7 @@ TEST_P(EnumerateHeaderLinesTest, EnumerateHeaderLines) {

std::string name, value, lines;

- void* iter = NULL;

+ size_t iter = 0;

while (parsed->EnumerateHeaderLines(&iter, &name, &value)) {

lines.append(name);

lines.append(": ");

« no previous file with comments | « net/http/http_response_headers.cc ('k') | net/spdy/spdy_http_utils.cc » ('j') | no next file with comments »