extensions/browser/api/web_request/web_request_api_helpers.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/mime_handler_private/mime_handler_private.cc ('k') | extensions/browser/api/web_request/web_request_event_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_api_helpers.cc

diff --git a/extensions/browser/api/web_request/web_request_api_helpers.cc b/extensions/browser/api/web_request/web_request_api_helpers.cc

index 6f86bf43943515ad524872c9bac3dca439769263..c998367f31af51656972522c7a983b1e9ce0184d 100644

--- a/extensions/browser/api/web_request/web_request_api_helpers.cc

+++ b/extensions/browser/api/web_request/web_request_api_helpers.cc

@@ -378,7 +378,7 @@ EventResponseDelta* CalculateOnHeadersReceivedDelta(

// Find deleted headers (header keys are treated case insensitively).

{

- void* iter = NULL;

+ size_t iter = 0;

std::string name;

std::string value;

while (old_response_headers->EnumerateHeaderLines(&iter, &name, &value)) {

@@ -401,7 +401,7 @@ EventResponseDelta* CalculateOnHeadersReceivedDelta(

{

for (const auto& i : *new_response_headers) {

std::string name_lowercase = base::ToLowerASCII(i.first);

- void* iter = nullptr;

+ size_t iter = 0;

std::string name;

std::string value;

bool header_found = false;