Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: components/cronet/android/chromium_url_request.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/android/chromium_url_request.h" 5 #include "components/cronet/android/chromium_url_request.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "components/cronet/android/url_request_adapter.h" 10 #include "components/cronet/android/url_request_adapter.h"
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 jlong jurl_request_adapter, 369 jlong jurl_request_adapter,
370 const JavaParamRef<jobject>& jheaders_map) { 370 const JavaParamRef<jobject>& jheaders_map) {
371 URLRequestAdapter* request_adapter = 371 URLRequestAdapter* request_adapter =
372 reinterpret_cast<URLRequestAdapter*>(jurl_request_adapter); 372 reinterpret_cast<URLRequestAdapter*>(jurl_request_adapter);
373 DCHECK(request_adapter); 373 DCHECK(request_adapter);
374 374
375 net::HttpResponseHeaders* headers = request_adapter->GetResponseHeaders(); 375 net::HttpResponseHeaders* headers = request_adapter->GetResponseHeaders();
376 if (headers == NULL) 376 if (headers == NULL)
377 return; 377 return;
378 378
379 void* iter = NULL; 379 size_t iter = 0;
380 std::string header_name; 380 std::string header_name;
381 std::string header_value; 381 std::string header_value;
382 while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) { 382 while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {
383 ScopedJavaLocalRef<jstring> name = 383 ScopedJavaLocalRef<jstring> name =
384 ConvertUTF8ToJavaString(env, header_name); 384 ConvertUTF8ToJavaString(env, header_name);
385 ScopedJavaLocalRef<jstring> value = 385 ScopedJavaLocalRef<jstring> value =
386 ConvertUTF8ToJavaString(env, header_value); 386 ConvertUTF8ToJavaString(env, header_value);
387 Java_ChromiumUrlRequest_onAppendResponseHeader(env, jcaller, jheaders_map, 387 Java_ChromiumUrlRequest_onAppendResponseHeader(env, jcaller, jheaders_map,
388 name.obj(), value.obj()); 388 name.obj(), value.obj());
389 } 389 }
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 static void DisableRedirects(JNIEnv* env, 422 static void DisableRedirects(JNIEnv* env,
423 const JavaParamRef<jobject>& jcaller, 423 const JavaParamRef<jobject>& jcaller,
424 jlong jrequest_adapter) { 424 jlong jrequest_adapter) {
425 URLRequestAdapter* request_adapter = 425 URLRequestAdapter* request_adapter =
426 reinterpret_cast<URLRequestAdapter*>(jrequest_adapter); 426 reinterpret_cast<URLRequestAdapter*>(jrequest_adapter);
427 DCHECK(request_adapter); 427 DCHECK(request_adapter);
428 request_adapter->DisableRedirects(); 428 request_adapter->DisableRedirects();
429 } 429 }
430 430
431 } // namespace cronet 431 } // namespace cronet
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/threat_details_cache.cc ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698