android_webview/native/aw_contents_io_thread_client_impl.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_io_thread_client_impl.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_contents_io_thread_client_impl.cc

diff --git a/android_webview/native/aw_contents_io_thread_client_impl.cc b/android_webview/native/aw_contents_io_thread_client_impl.cc

index d00b26043cce7e60c45b4c67da6ce5dbd2024ccc..674832dce1d2a5d0c2481cb8662b96504ec026d5 100644

--- a/android_webview/native/aw_contents_io_thread_client_impl.cc

+++ b/android_webview/native/aw_contents_io_thread_client_impl.cc

@@ -466,7 +466,7 @@ void AwContentsIoThreadClientImpl::OnReceivedHttpError(

vector<string> response_header_names;

vector<string> response_header_values;

{

- void* headers_iterator = NULL;

+ size_t headers_iterator = 0;

string header_name, header_value;

while (response_headers->EnumerateHeaderLines(

&headers_iterator, &header_name, &header_value)) {

« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »