Convert Pass()→std::move() in //chrome (Android edition)

Convert Pass()→std::move() in //chrome (Android edition)

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=thestig@chromium.org

Committed: https://crrev.com/bc6125df1e4a4a1b4fcc14734386f8a94916088c
Cr-Commit-Position: refs/heads/master@{#367128}

[dcheng, 2015-12-29 23:47:56]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-29 23:48:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551033002/1

[Lei Zhang, 2015-12-29 23:59:31]

https://codereview.chromium.org/1551033002/diff/1/chrome/browser/android/dev_...
File chrome/browser/android/dev_tools_server.cc (right):

https://codereview.chromium.org/1551033002/diff/1/chrome/browser/android/dev_...
chrome/browser/android/dev_tools_server.cc:179: return std::move(socket);
Do you need the std::move() here?

[Lei Zhang, 2015-12-30 00:03:33]

lgtm

[dcheng, 2015-12-30 00:08:53]

https://codereview.chromium.org/1551033002/diff/1/chrome/browser/android/dev_...
File chrome/browser/android/dev_tools_server.cc (right):

https://codereview.chromium.org/1551033002/diff/1/chrome/browser/android/dev_...
chrome/browser/android/dev_tools_server.cc:179: return std::move(socket);
On 2015/12/29 at 23:59:30, Lei Zhang wrote:
> Do you need the std::move() here?

Yes, since this converts from scoped_ptr<net::UnixDomainServerSocket> to
scoped_ptr<net::ServerSocket>.

I've fixed this particular instance to just make the types match (but in
general, this is not something that's easy to catch automatically)

[dcheng, 2015-12-30 00:08:59]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-12-30 00:09:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1551033002/#ps20001
(title: "Enable RVO by making types match")

[commit-bot: I haz the power, 2015-12-30 00:09:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551033002/20001

[commit-bot: I haz the power, 2015-12-30 01:54:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-30 01:54:59]

Description was changed from

==========
Convert Pass()→std::move() in //chrome (Android edition)

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=thestig@chromium.org
==========

to

==========
Convert Pass()→std::move() in //chrome (Android edition)

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=thestig@chromium.org

Committed: https://crrev.com/bc6125df1e4a4a1b4fcc14734386f8a94916088c
Cr-Commit-Position: refs/heads/master@{#367128}
==========

[commit-bot: I haz the power, 2015-12-30 01:55:00]

Patchset 2 (id:??) landed as
https://crrev.com/bc6125df1e4a4a1b4fcc14734386f8a94916088c
Cr-Commit-Position: refs/heads/master@{#367128}