Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3073)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable RVO by making types match Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/bookmarks/bookmarks_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index 13745f3af25063d57e202972bcec4a3a654f3699..873d31a02fea8f340f59f5b32119fc9b8de7ee98 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
+#include <utility>
+
#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
#include "chrome/browser/android/shortcut_helper.h"
#include "chrome/browser/banners/app_banner_metrics.h"
@@ -86,8 +88,8 @@ void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
event_request_id(), this, title, new SkBitmap(*icon),
web_app_data()));
- infobar =
- new AppBannerInfoBarAndroid(delegate.Pass(), web_app_data().start_url);
+ infobar = new AppBannerInfoBarAndroid(std::move(delegate),
+ web_app_data().start_url);
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
@@ -97,7 +99,8 @@ void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
new AppBannerInfoBarDelegateAndroid(
event_request_id(), title, new SkBitmap(*icon), native_app_data_,
native_app_package_, referrer));
- infobar = new AppBannerInfoBarAndroid(delegate.Pass(), native_app_data_);
+ infobar =
+ new AppBannerInfoBarAndroid(std::move(delegate), native_app_data_);
if (infobar) {
RecordDidShowBanner("AppBanner.NativeApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);
« no previous file with comments | « no previous file | chrome/browser/android/bookmarks/bookmarks_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698