chrome/browser/android/history_report/usage_reports_buffer_service.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/usage_reports_buffer_service.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/usage_reports_buffer_backend.cc ('k') | chrome/browser/android/media/media_throttle_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/usage_reports_buffer_service.cc

diff --git a/chrome/browser/android/history_report/usage_reports_buffer_service.cc b/chrome/browser/android/history_report/usage_reports_buffer_service.cc

index 4d8680da05faa9436e35cd329ba0ab89c4e037a5..6cbc01c6abfee641bec6c9d4b7a9d7dd931c6cff 100644

--- a/chrome/browser/android/history_report/usage_reports_buffer_service.cc

+++ b/chrome/browser/android/history_report/usage_reports_buffer_service.cc

@@ -37,7 +37,7 @@ void DoGetUsageReportsBatch(

int32_t batch_size,

base::WaitableEvent* finished,

scoped_ptr<std::vector<history_report::UsageReport>>* result) {

- *result = backend->GetUsageReportsBatch(batch_size).Pass();

+ *result = backend->GetUsageReportsBatch(batch_size);

finished->Signal();

}

@@ -110,7 +110,7 @@ UsageReportsBufferService::GetUsageReportsBatch(int32_t batch_size) {

base::Unretained(&result)),

base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);

finished.Wait();

- return result.Pass();

+ return result;

}

void UsageReportsBufferService::Remove(