chrome/browser/media/android/remote/remote_media_player_bridge.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/remote/remote_media_player_bridge.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/interests/android/interests_service.cc ('k') | chrome/browser/media/android/router/media_router_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/android/remote/remote_media_player_bridge.cc

diff --git a/chrome/browser/media/android/remote/remote_media_player_bridge.cc b/chrome/browser/media/android/remote/remote_media_player_bridge.cc

index 9645dcb0ed2a5e911037aa8d766b24b378da9ded..04ed30314a2cee1adfa47ae9915fbdbffba2037d 100644

--- a/chrome/browser/media/android/remote/remote_media_player_bridge.cc

+++ b/chrome/browser/media/android/remote/remote_media_player_bridge.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/media/android/remote/remote_media_player_bridge.h"

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

#include "chrome/browser/media/android/remote/record_cast_action.h"

@@ -170,7 +172,7 @@ void RemoteMediaPlayerBridge::SetVideoSurface(gfx::ScopedJavaSurface surface) {

// Since the remote player doesn't use it, we forward it to the local player

// for the time when user disconnects and resumes local playback

// (see crbug.com/420690).

- local_player_->SetVideoSurface(surface.Pass());

+ local_player_->SetVideoSurface(std::move(surface));

}

base::android::ScopedJavaLocalRef<jstring> RemoteMediaPlayerBridge::GetFrameUrl(