Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/android/most_visited_sites.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable RVO by making types match Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/most_visited_sites.cc
diff --git a/chrome/browser/android/most_visited_sites.cc b/chrome/browser/android/most_visited_sites.cc
index c3001eb3fd2b124e74b5033e4ebebd878b73a99c..6804472855bf854f853b2653ec5d238badf0cf5d 100644
--- a/chrome/browser/android/most_visited_sites.cc
+++ b/chrome/browser/android/most_visited_sites.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/android/most_visited_sites.h"
+#include <utility>
+
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
@@ -93,7 +95,7 @@ scoped_ptr<SkBitmap> MaybeFetchLocalThumbnail(
scoped_ptr<SkBitmap> bitmap;
if (top_sites && top_sites->GetPageThumbnail(url, false, &image))
bitmap.reset(gfx::JPEGCodec::Decode(image->front(), image->size()));
- return bitmap.Pass();
+ return bitmap;
}
// Log an event for a given |histogram| at a given element |position|. This
@@ -331,7 +333,7 @@ void MostVisitedSites::OnLocalThumbnailFetched(
}
}
}
- OnObtainedThumbnail(true, j_callback.Pass(), url, bitmap.get());
+ OnObtainedThumbnail(true, std::move(j_callback), url, bitmap.get());
}
void MostVisitedSites::OnObtainedThumbnail(
@@ -588,7 +590,7 @@ ScopedVector<MostVisitedSites::Suggestion> MostVisitedSites::MergeSuggestions(
// Insert leftover popular suggestions.
InsertAllSuggestions(filled_so_far, new_popular_suggestions,
popular_suggestions, &merged_suggestions);
- return merged_suggestions.Pass();
+ return merged_suggestions;
}
void MostVisitedSites::GetPreviousNTPSites(

Powered by Google App Engine
This is Rietveld 408576698