chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/confirm_infobar.cc ('k') | chrome/browser/ui/android/infobars/download_overwrite_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc b/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc

index f44def98c6b7998f0085f18d7be7a66e71a05913..0153ce7871308f18335a4c5fe7420922d222e3e5 100644

--- a/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc

+++ b/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h"

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

#include "base/logging.h"

@@ -31,7 +33,8 @@ bool DataReductionProxyInfoBar::Register(JNIEnv* env) {

DataReductionProxyInfoBar::DataReductionProxyInfoBar(

scoped_ptr<DataReductionProxyInfoBarDelegateAndroid> delegate)

- : ConfirmInfoBar(delegate.Pass()), java_data_reduction_proxy_delegate_() {}

+ : ConfirmInfoBar(std::move(delegate)),

+ java_data_reduction_proxy_delegate_() {}

DataReductionProxyInfoBar::~DataReductionProxyInfoBar() {

}

@@ -58,7 +61,7 @@ DataReductionProxyInfoBarDelegateAndroid::CreateInfoBar(

infobars::InfoBarManager* infobar_manager,

scoped_ptr<DataReductionProxyInfoBarDelegateAndroid> delegate) {

return scoped_ptr<infobars::InfoBar>(

- new DataReductionProxyInfoBar(delegate.Pass()));

+ new DataReductionProxyInfoBar(std::move(delegate)));

}

// JNI for DataReductionProxyInfoBarDelegate.