chrome/browser/android/offline_pages/offline_page_model_factory.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_model_factory.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_model_factory.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_model_factory.cc b/chrome/browser/android/offline_pages/offline_page_model_factory.cc

index cb9e9f57a5a3157e59159c368938531d8ba9bbe4..9195443f5ba12f2bdd9c9259c8839d13aa4809e4 100644

--- a/chrome/browser/android/offline_pages/offline_page_model_factory.cc

+++ b/chrome/browser/android/offline_pages/offline_page_model_factory.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"

+#include <utility>

#include "base/files/file_path.h"

#include "base/memory/singleton.h"

#include "base/path_service.h"

@@ -52,7 +54,7 @@ KeyedService* OfflinePageModelFactory::BuildServiceInstanceFor(

base::FilePath archives_dir =

profile->GetPath().Append(chrome::kOfflinePageArchviesDirname);

- return new OfflinePageModel(metadata_store.Pass(), archives_dir,

+ return new OfflinePageModel(std::move(metadata_store), archives_dir,

background_task_runner);

}