chrome/browser/download/download_resource_throttle.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_resource_throttle.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/geolocation/geolocation_permission_context_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_resource_throttle.cc

diff --git a/chrome/browser/download/download_resource_throttle.cc b/chrome/browser/download/download_resource_throttle.cc

index 9d6a56641ef345850c6fb891a1ef24967fdea27c..fae860e9b3dd2b8559413bb1ac2aa528eea0a7e9 100644

--- a/chrome/browser/download/download_resource_throttle.cc

+++ b/chrome/browser/download/download_resource_throttle.cc

@@ -43,7 +43,7 @@ void OnAcquireFileAccessPermissionDone(

bool granted) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (granted)

- CanDownload(info.Pass());

+ CanDownload(std::move(info));

else

info->continue_callback.Run(false);

}

@@ -55,10 +55,10 @@ void CanDownloadOnUIThread(

#if defined(OS_ANDROID)

content::WebContents* contents = info->web_contents_getter.Run();

if (!contents)

- OnAcquireFileAccessPermissionDone(info.Pass(), false);

+ OnAcquireFileAccessPermissionDone(std::move(info), false);

content::DownloadControllerAndroid::Get()->AcquireFileAccessPermission(

contents, base::Bind(&OnAcquireFileAccessPermissionDone,

- base::Passed(info.Pass())));

+ base::Passed(std::move(info))));

#else

CanDownload(std::move(info));

#endif