chrome/browser/android/history_report/usage_reports_buffer_backend.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/usage_reports_buffer_backend.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/delta_file_service.cc ('k') | chrome/browser/android/history_report/usage_reports_buffer_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/usage_reports_buffer_backend.cc

diff --git a/chrome/browser/android/history_report/usage_reports_buffer_backend.cc b/chrome/browser/android/history_report/usage_reports_buffer_backend.cc

index 5171a6412b4f3e67299352d6c1a02649adb32af0..36c1ca87eacab665115acb0ecf0c7d9fa960bbfe 100644

--- a/chrome/browser/android/history_report/usage_reports_buffer_backend.cc

+++ b/chrome/browser/android/history_report/usage_reports_buffer_backend.cc

@@ -81,7 +81,7 @@ scoped_ptr<std::vector<UsageReport> >

UsageReportsBufferBackend::GetUsageReportsBatch(int batch_size) {

scoped_ptr<std::vector<UsageReport> > reports(new std::vector<UsageReport>());

if (!db_.get()) {

- return reports.Pass();

+ return reports;

}

reports->reserve(batch_size);

leveldb::ReadOptions options;

@@ -96,7 +96,7 @@ UsageReportsBufferBackend::GetUsageReportsBatch(int batch_size) {

}

db_iter->Next();

}

- return reports.Pass();

+ return reports;

}

void UsageReportsBufferBackend::Remove(