chrome/browser/android/feedback/connectivity_checker.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/feedback/connectivity_checker.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/feedback/connectivity_checker.cc

diff --git a/chrome/browser/android/feedback/connectivity_checker.cc b/chrome/browser/android/feedback/connectivity_checker.cc

index 5e70d3477f318e05a912efa45b73410d54112e79..e915e2bfc46922156077e7131dc30f843eb1c9bf 100644

--- a/chrome/browser/android/feedback/connectivity_checker.cc

+++ b/chrome/browser/android/feedback/connectivity_checker.cc

@@ -136,8 +136,7 @@ ConnectivityChecker::ConnectivityChecker(

}

void ConnectivityChecker::StartAsyncCheck() {

- url_fetcher_ =

- net::URLFetcher::Create(url_, net::URLFetcher::GET, this).Pass();

+ url_fetcher_ = net::URLFetcher::Create(url_, net::URLFetcher::GET, this);

url_fetcher_->SetRequestContext(request_context_);

url_fetcher_->SetStopOnRedirect(true);

url_fetcher_->SetAutomaticallyRetryOn5xx(false);

« no previous file with comments | « chrome/browser/android/dev_tools_server.cc ('k') | chrome/browser/android/history_report/data_provider.cc » ('j') | no next file with comments »