chrome/browser/password_manager/account_chooser_dialog_android.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc ('k') | chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/account_chooser_dialog_android.cc

diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc

index 6b75669233b056ba62b7274824608c5be4b6ded3..833980783bf98991ebb8999e77f9263908f5973b 100644

--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc

+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/password_manager/account_chooser_dialog_android.h"

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

#include "base/android/scoped_java_ref.h"

@@ -110,8 +112,8 @@ AccountChooserDialogAndroid::AccountChooserDialogAndroid(

: web_contents_(web_contents) {

passwords_data_.set_client(

ChromePasswordManagerClient::FromWebContents(web_contents_));

- passwords_data_.OnRequestCredentials(local_credentials.Pass(),

- federated_credentials.Pass(), origin);

+ passwords_data_.OnRequestCredentials(

+ std::move(local_credentials), std::move(federated_credentials), origin);

passwords_data_.set_credentials_callback(callback);

}