chrome/browser/ui/android/infobars/translate_infobar.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/translate_infobar.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/save_password_infobar.cc ('k') | chrome/browser/ui/android/ssl_client_certificate_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/translate_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/translate_infobar.cc b/chrome/browser/ui/android/infobars/translate_infobar.cc

index 85e90208e2b917b556a4a319bd1a5091fbddb96e..effcb53a0ae3c0041ca1d685f099c1f759bcbb37 100644

--- a/chrome/browser/ui/android/infobars/translate_infobar.cc

+++ b/chrome/browser/ui/android/infobars/translate_infobar.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/android/infobars/translate_infobar.h"

#include <stddef.h>

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_array.h"

@@ -19,7 +20,7 @@

scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

scoped_ptr<translate::TranslateInfoBarDelegate> delegate) const {

- return make_scoped_ptr(new TranslateInfoBar(delegate.Pass()));

+ return make_scoped_ptr(new TranslateInfoBar(std::move(delegate)));

}

@@ -27,8 +28,7 @@ scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

TranslateInfoBar::TranslateInfoBar(

scoped_ptr<translate::TranslateInfoBarDelegate> delegate)

- : InfoBarAndroid(delegate.Pass()) {

+ : InfoBarAndroid(std::move(delegate)) {}

TranslateInfoBar::~TranslateInfoBar() {

}