chrome/browser/android/history_report/delta_file_service.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/delta_file_service.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/delta_file_backend_leveldb.cc ('k') | chrome/browser/android/history_report/usage_reports_buffer_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/delta_file_service.cc

diff --git a/chrome/browser/android/history_report/delta_file_service.cc b/chrome/browser/android/history_report/delta_file_service.cc

index ce0f661797840e2761e0f0b7d7f159136d73c383..9af69e13d3e23e3e11d13c034de571a900240c2f 100644

--- a/chrome/browser/android/history_report/delta_file_service.cc

+++ b/chrome/browser/android/history_report/delta_file_service.cc

@@ -36,7 +36,7 @@ void DoQuery(

int32_t limit,

base::WaitableEvent* finished,

scoped_ptr<std::vector<history_report::DeltaFileEntryWithData>>* result) {

- *result = backend->Query(last_seq_no, limit).Pass();

+ *result = backend->Query(last_seq_no, limit);

finished->Signal();

}

@@ -128,7 +128,7 @@ scoped_ptr<std::vector<DeltaFileEntryWithData>> DeltaFileService::Query(

base::Unretained(&result)),

base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);

finished.Wait();

- return result.Pass();

+ return result;

}

bool DeltaFileService::Recreate(const std::vector<std::string>& urls) {