chrome/browser/ui/android/infobars/download_overwrite_infobar.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc ('k') | chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc b/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

index 47808766b93087948b4b2a6019ecdff4a3cd3478..5dbfb220757141cfac189b04f32c7222d7521e6e 100644

--- a/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

+++ b/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/android/infobars/download_overwrite_infobar.h"

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_array.h"

#include "base/android/jni_string.h"

@@ -17,7 +19,7 @@ using chrome::android::DownloadOverwriteInfoBarDelegate;

// static

scoped_ptr<infobars::InfoBar> DownloadOverwriteInfoBar::CreateInfoBar(

scoped_ptr<DownloadOverwriteInfoBarDelegate> delegate) {

- return make_scoped_ptr(new DownloadOverwriteInfoBar(delegate.Pass()));

+ return make_scoped_ptr(new DownloadOverwriteInfoBar(std::move(delegate)));

}

DownloadOverwriteInfoBar::~DownloadOverwriteInfoBar() {

@@ -25,8 +27,7 @@ DownloadOverwriteInfoBar::~DownloadOverwriteInfoBar() {

DownloadOverwriteInfoBar::DownloadOverwriteInfoBar(

scoped_ptr<DownloadOverwriteInfoBarDelegate> delegate)

- : InfoBarAndroid(delegate.Pass()) {

+ : InfoBarAndroid(std::move(delegate)) {}

base::android::ScopedJavaLocalRef<jobject>

DownloadOverwriteInfoBar::CreateRenderInfoBar(JNIEnv* env) {