Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1443743002: Rename some processor functions from GL to GLSL (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@primProcs
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename some processor functions from GL to GLSL TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/57d3b039c635945e1dc2fcbac3462ed8bfedb068

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -362 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/dcshader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 3 chunks +9 lines, -8 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 3 chunks +7 lines, -6 lines 0 comments Download
M include/gpu/effects/GrConstColorProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLightingShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 4 chunks +11 lines, -10 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 5 chunks +17 lines, -16 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 7 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 4 chunks +11 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
egdaniel
Hopefully, last big name changing CL for a bit
5 years, 1 month ago (2015-11-13 18:54:28 UTC) #2
joshualitt
lgtm + nit https://codereview.chromium.org/1443743002/diff/1/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/1443743002/diff/1/src/effects/SkBlurMaskFilter.cpp#newcode1134 src/effects/SkBlurMaskFilter.cpp:1134: void GrRRectBlurEffect::onGetGLSLProcessorKey(const GrGLSLCaps& caps, GrProcessorKeyBuilder* b) ...
5 years, 1 month ago (2015-11-13 18:57:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443743002/20001
5 years, 1 month ago (2015-11-13 19:24:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 19:37:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443743002/20001
5 years, 1 month ago (2015-11-13 19:56:30 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 19:57:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/57d3b039c635945e1dc2fcbac3462ed8bfedb068

Powered by Google App Engine
This is Rietveld 408576698