Move Source/WTF/wtf to Source/wtf

Move Source/WTF/wtf to Source/wtf

This move removes some stutter from our directory names and paves the way for
sensible looking include paths from the Source directory (e.g., #include
"wtf/RefPtr.h").

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148483

[eseidel, 2013-04-16 18:02:07]

rs=me.  lgtm

[eseidel, 2013-04-16 18:03:25]

You follow-up on the thread on blink-dev about moving the headers to use
full-paths, and tell the contributor that they're now good to go ahead changing
all wtf includes to use full paths.

[abarth-chromium, 2013-04-16 18:06:14]

Committed patchset #1 manually as r148483 (presubmit successful).

[jochen (gone - plz use gerrit), 2013-04-26 19:53:45]

https://codereview.chromium.org/14238015/diff/1/Source/config.h
File Source/config.h (right):

https://codereview.chromium.org/14238015/diff/1/Source/config.h#newcode1
Source/config.h:1: /*
moving this file to Source/ strikes me as problematic, as embedders shouldn't
include it. However, we're adding Source/ as include directory everywhere, so
it's super easy to include by accident, e.g. from the TestRunner library (which
happens to have it's own config.h)

[abarth-chromium, 2013-04-26 20:35:14]

On 2013/04/26 19:53:45, jochen wrote:
> https://codereview.chromium.org/14238015/diff/1/Source/config.h
> File Source/config.h (right):
> 
> https://codereview.chromium.org/14238015/diff/1/Source/config.h#newcode1
> Source/config.h:1: /*
> moving this file to Source/ strikes me as problematic, as embedders shouldn't
> include it. However, we're adding Source/ as include directory everywhere, so
> it's super easy to include by accident, e.g. from the TestRunner library
(which
> happens to have it's own config.h)

TestRunner shouldn't have Source on it's include path.  Life will get easier
when we move the "public" directories outside of Source directory.

[jochen (gone - plz use gerrit), 2013-04-26 20:39:38]

On 2013/04/26 20:35:14, abarth wrote:
> On 2013/04/26 19:53:45, jochen wrote:
> > https://codereview.chromium.org/14238015/diff/1/Source/config.h
> > File Source/config.h (right):
> > 
> > https://codereview.chromium.org/14238015/diff/1/Source/config.h#newcode1
> > Source/config.h:1: /*
> > moving this file to Source/ strikes me as problematic, as embedders
shouldn't
> > include it. However, we're adding Source/ as include directory everywhere,
so
> > it's super easy to include by accident, e.g. from the TestRunner library
> (which
> > happens to have it's own config.h)
> 
> TestRunner shouldn't have Source on it's include path.  Life will get easier
> when we move the "public" directories outside of Source directory.

Well, it used to have Source in its include path before it was cool :)

The reason is that the library is also included from chromium where we require
full paths, so we decided to use paths relative to Source/

I guess we could change TestRunner to include third_party/WebKit in its path. Or
I try to get rid of its config.h

[jamesr, 2013-04-26 20:42:10]

On 2013/04/26 20:39:38, jochen wrote:
> I guess we could change TestRunner to include third_party/WebKit in its path.

Yes - we don't have to support the Chromium-inside-WebKit configuration, so this
seems like the best approach.

[abarth-chromium, 2013-04-26 21:16:01]

On 2013/04/26 20:42:10, jamesr wrote:
> On 2013/04/26 20:39:38, jochen wrote:
> > I guess we could change TestRunner to include third_party/WebKit in its
path.
> 
> Yes - we don't have to support the Chromium-inside-WebKit configuration, so
this
> seems like the best approach.

Don't we want it to just use paths from Chromium's src directory?  So,

#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h" ?

[jamesr, 2013-04-26 21:18:08]

On 2013/04/26 21:16:01, abarth wrote:
> On 2013/04/26 20:42:10, jamesr wrote:
> > On 2013/04/26 20:39:38, jochen wrote:
> > > I guess we could change TestRunner to include third_party/WebKit in its
> path.
> > 
> > Yes - we don't have to support the Chromium-inside-WebKit configuration, so
> this
> > seems like the best approach.
> 
> Don't we want it to just use paths from Chromium's src directory?  So,
> 
> #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h" ?

Sorry yes, that's what I meant.  The TestRunner files should #include the full
path, including the third_party/WebKit/... bit

(it'll be a bit of a pain to migrate these once we do the src/blink move, but no
more than all the other #includes)