ui/gl: Move GLImage into gl namespace.

ui/gl: Move GLImage into gl namespace.

BUG=461575
R=piman@chromium.org,sievers@chromium.org,
TBR=fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/df856e02c830fb37ca5afceac7a12b4bddf37a84
Cr-Commit-Position: refs/heads/master@{#356825}

[tfarina, 2015-10-27 00:40:26]

Should be good now. I will fix any failures reported by the trybots.

PTAL

[piman, 2015-10-27 01:11:26]

there's a couple of compile issues left apparently. I think we should move the
derived classes to, there's no reason not to (it may even actually simplify the
CL a bit).

https://codereview.chromium.org/1421903006/diff/40001/ui/gl/gl_image_egl.h
File ui/gl/gl_image_egl.h (right):

https://codereview.chromium.org/1421903006/diff/40001/ui/gl/gl_image_egl.h#ne...
ui/gl/gl_image_egl.h:12: namespace gfx {
I think it would be good to move the derived classes into the gl namespace at
the same time.

[tfarina, 2015-10-28 03:58:40]

Antoine, I think this is in a good size. For me it is already exploding and
making hard to fix the compile failures.

I would be happy if I could land it without more changes ;)

PTAL.

https://codereview.chromium.org/1421903006/diff/40001/ui/gl/gl_image_egl.h
File ui/gl/gl_image_egl.h (right):

https://codereview.chromium.org/1421903006/diff/40001/ui/gl/gl_image_egl.h#ne...
ui/gl/gl_image_egl.h:12: namespace gfx {
On 2015/10/27 01:11:26, piman (slow to review) wrote:
> I think it would be good to move the derived classes into the gl namespace at
> the same time.
Done.

[piman, 2015-10-28 16:59:00]

LGTM after compile issues are fixed. Please prioritize moving the remaining
derived classes so that we don't stay in this awkward state too long.

[tfarina, 2015-10-28 18:16:52]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 18:16:53]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1421903006/#ps240001
(title: "fixes")

[commit-bot: I haz the power, 2015-10-28 18:18:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/240001

[commit-bot: I haz the power, 2015-10-28 18:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 18:29:03]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tfarina, 2015-10-28 18:35:31]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 18:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1421903006/#ps260001
(title: "gl::GLImageSharedMemory")

[commit-bot: I haz the power, 2015-10-28 18:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/260001

[commit-bot: I haz the power, 2015-10-28 18:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 18:54:19]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2015-10-28 19:06:00]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 19:06:01]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1421903006/#ps280001
(title: "gl::GLImageSharedMemory")

[commit-bot: I haz the power, 2015-10-28 19:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/280001

[commit-bot: I haz the power, 2015-10-28 19:18:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 19:18:01]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2015-10-28 19:27:04]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 19:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1421903006/#ps300001
(title: "gl::GLImageGLX")

[commit-bot: I haz the power, 2015-10-28 19:28:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/300001

[commit-bot: I haz the power, 2015-10-28 19:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 19:40:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2015-10-28 19:43:41]

tfarina@chromium.org changed reviewers:
+ fsamuel@chromium.org

[tfarina, 2015-10-28 19:43:42]

+Fady for components/mus/gles2!

[tfarina, 2015-10-28 19:43:56]

Description was changed from

==========
ui/gl: Move GLImage into gl namespace.

BUG=461575
R=piman@chromium.org,sievers@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
ui/gl: Move GLImage into gl namespace.

BUG=461575
R=piman@chromium.org,sievers@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tfarina, 2015-10-28 20:54:41]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 20:54:41]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1421903006/#ps290071
(title: "ozone demo")

[commit-bot: I haz the power, 2015-10-28 20:55:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/290071
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/290071

[commit-bot: I haz the power, 2015-10-28 21:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 21:06:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2015-10-29 11:49:50]

Description was changed from

==========
ui/gl: Move GLImage into gl namespace.

BUG=461575
R=piman@chromium.org,sievers@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
ui/gl: Move GLImage into gl namespace.

BUG=461575
R=piman@chromium.org,sievers@chromium.org,
TBR=fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tfarina, 2015-10-29 11:49:58]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-10-29 11:50:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421903006/290071
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421903006/290071

[commit-bot: I haz the power, 2015-10-29 12:50:53]

Committed patchset #18 (id:290071)

[commit-bot: I haz the power, 2015-10-29 12:51:31]

Patchset 18 (id:??) landed as
https://crrev.com/df856e02c830fb37ca5afceac7a12b4bddf37a84
Cr-Commit-Position: refs/heads/master@{#356825}

[reveman, 2015-10-29 19:46:40]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2015-10-29 19:46:42]

https://codereview.chromium.org/1421903006/diff/290071/ui/gl/test/gl_image_te...
File ui/gl/test/gl_image_test_template.h (right):

https://codereview.chromium.org/1421903006/diff/290071/ui/gl/test/gl_image_te...
ui/gl/test/gl_image_test_template.h:61: scoped_refptr<gl::GLImage> small_image =
All these tests classes will be moved to gl namespace in follow up patches too,
correct?

[tfarina, 2015-10-29 20:52:05]

https://codereview.chromium.org/1421903006/diff/290071/ui/gl/test/gl_image_te...
File ui/gl/test/gl_image_test_template.h (right):

https://codereview.chromium.org/1421903006/diff/290071/ui/gl/test/gl_image_te...
ui/gl/test/gl_image_test_template.h:61: scoped_refptr<gl::GLImage> small_image =
On 2015/10/29 19:46:42, reveman wrote:
> All these tests classes will be moved to gl namespace in follow up patches
too,
> correct? 

Correct.