Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extern in .cpp file is a code smell, part 2. Fixes the remaining issues, except for JBIG2/Skia ... R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c3f4894a6862c74b9ab32b4ec38c531de6ecd83c

Patch Set 1 #

Patch Set 2 : Stray file. #

Total comments: 6

Patch Set 3 : Rename, remove dead fn. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -122 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +13 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/cmap_int.h View 1 chunk +7 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 2 chunks +34 lines, -31 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M core/src/fxge/dib/dib_int.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 2 5 chunks +4 lines, -14 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, for review. Second half of the previous.
5 years, 4 months ago (2015-08-19 17:53:34 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1298393003/diff/20001/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1298393003/diff/20001/core/include/fxge/fx_font.h#newcode439 core/include/fxge/fx_font.h:439: CFX_ByteString FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name); FPDF_Foo() is ...
5 years, 4 months ago (2015-08-19 19:31:15 UTC) #3
Tom Sepez
https://codereview.chromium.org/1298393003/diff/20001/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1298393003/diff/20001/core/include/fxge/fx_font.h#newcode439 core/include/fxge/fx_font.h:439: CFX_ByteString FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name); On 2015/08/19 19:31:14, ...
5 years, 4 months ago (2015-08-19 20:25:34 UTC) #4
Tom Sepez
5 years, 4 months ago (2015-08-19 20:25:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c3f4894a6862c74b9ab32b4ec38c531de6ecd83c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698