core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

index 0d7bdd83795cfb4670d0c28de064904451fa8f6c..02ff1f3aca541002ce07df307e368a7276824b72 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

@@ -86,7 +86,6 @@ void CPDF_Document::LoadAsynDoc(CPDF_Dictionary* pLinearized) {

void CPDF_Document::LoadPages() {

m_PageList.SetSize(_GetPageCount());

}

-extern void FPDF_TTFaceMapper_ReleaseDoc(CPDF_Document*);

CPDF_Document::~CPDF_Document() {

if (m_pDocPage) {

CPDF_ModuleMgr::Get()->GetPageModule()->ReleaseDoc(this);