fpdfsdk/include/fxedit/fx_edit.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/include/fxedit/fx_edit.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « fpdfsdk/include/fsdk_define.h ('k') | fpdfsdk/src/fpdf_dataavail.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_	7 #ifndef FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_

8 #define FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_	8 #define FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_

9	9

10 #include "../../../core/include/fxcrt/fx_basic.h"	10 #include "../../../core/include/fxcrt/fx_basic.h"

(...skipping 550 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
561 virtual void OnVK_RIGHT(FX_BOOL bShift, FX_BOOL bCtrl) = 0;	561 virtual void OnVK_RIGHT(FX_BOOL bShift, FX_BOOL bCtrl) = 0;

562 virtual void OnVK_HOME(FX_BOOL bShift, FX_BOOL bCtrl) = 0;	562 virtual void OnVK_HOME(FX_BOOL bShift, FX_BOOL bCtrl) = 0;

563 virtual void OnVK_END(FX_BOOL bShift, FX_BOOL bCtrl) = 0;	563 virtual void OnVK_END(FX_BOOL bShift, FX_BOOL bCtrl) = 0;

564 virtual void OnVK(int32_t nItemIndex, FX_BOOL bShift, FX_BOOL bCtrl) = 0;	564 virtual void OnVK(int32_t nItemIndex, FX_BOOL bShift, FX_BOOL bCtrl) = 0;

565 virtual FX_BOOL OnChar(FX_WORD nChar, FX_BOOL bShift, FX_BOOL bCtrl) = 0;	565 virtual FX_BOOL OnChar(FX_WORD nChar, FX_BOOL bShift, FX_BOOL bCtrl) = 0;

566	566

567 protected:	567 protected:

568 virtual ~IFX_List() {}	568 virtual ~IFX_List() {}

569 };	569 };

570	570

	571 CFX_ByteString GetPDFWordString(IFX_Edit_FontMap* pFontMap,

	572 int32_t nFontIndex,

	573 FX_WORD Word,

	574 FX_WORD SubWord);

	575

571 #endif // FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_	576 #endif // FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_

OLD	NEW