core/src/fxge/dib/dib_int.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/dib/dib_int.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_SRC_FXGE_DIB_DIB_INT_H_	7 #ifndef CORE_SRC_FXGE_DIB_DIB_INT_H_

8 #define CORE_SRC_FXGE_DIB_DIB_INT_H_	8 #define CORE_SRC_FXGE_DIB_DIB_INT_H_

9	9

	10 extern const int SDP_Table[513];

	11

10 class CPDF_FixedMatrix {	12 class CPDF_FixedMatrix {

11 public:	13 public:

12 CPDF_FixedMatrix(const CFX_AffineMatrix& src, int bits) {	14 CPDF_FixedMatrix(const CFX_AffineMatrix& src, int bits) {

13 base = 1 << bits;	15 base = 1 << bits;

14 a = FXSYS_round(src.a * base);	16 a = FXSYS_round(src.a * base);

15 b = FXSYS_round(src.b * base);	17 b = FXSYS_round(src.b * base);

16 c = FXSYS_round(src.c * base);	18 c = FXSYS_round(src.c * base);

17 d = FXSYS_round(src.d * base);	19 d = FXSYS_round(src.d * base);

18 e = FXSYS_round(src.e * base);	20 e = FXSYS_round(src.e * base);

19 f = FXSYS_round(src.f * base);	21 f = FXSYS_round(src.f * base);

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 int m_TransMethod;	84 int m_TransMethod;

83 int m_Flags;	85 int m_Flags;

84 CWeightTable m_WeightTable;	86 CWeightTable m_WeightTable;

85 int m_CurRow;	87 int m_CurRow;

86 FX_BOOL StartStretchHorz();	88 FX_BOOL StartStretchHorz();

87 FX_BOOL ContinueStretchHorz(IFX_Pause* pPause);	89 FX_BOOL ContinueStretchHorz(IFX_Pause* pPause);

88 void StretchVert();	90 void StretchVert();

89 int m_State;	91 int m_State;

90 };	92 };

91	93

	94 FX_RECT FXDIB_SwapClipBox(FX_RECT& clip,

	95 int width,

	96 int height,

	97 FX_BOOL bFlipX,

	98 FX_BOOL bFlipY);

	99

92 #endif // CORE_SRC_FXGE_DIB_DIB_INT_H_	100 #endif // CORE_SRC_FXGE_DIB_DIB_INT_H_

OLD	NEW

« no previous file with comments | « core/src/fpdftext/text_int.h ('k') | core/src/fxge/dib/fx_dib_engine.cpp » ('j') | no next file with comments »