core/src/fxge/ge/text_int.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/ge/text_int.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_SRC_FXGE_GE_TEXT_INT_H_	7 #ifndef CORE_SRC_FXGE_GE_TEXT_INT_H_

8 #define CORE_SRC_FXGE_GE_TEXT_INT_H_	8 #define CORE_SRC_FXGE_GE_TEXT_INT_H_

9	9

	10 #include "../../../include/fxge/fx_freetype.h"

	11

10 struct _CFX_UniqueKeyGen {	12 struct _CFX_UniqueKeyGen {

11 void Generate(int count, ...);	13 void Generate(int count, ...);

12 FX_CHAR m_Key[128];	14 FX_CHAR m_Key[128];

13 int m_KeyLen;	15 int m_KeyLen;

14 };	16 };

15 class CFX_SizeGlyphCache {	17 class CFX_SizeGlyphCache {

16 public:	18 public:

17 CFX_SizeGlyphCache() { m_GlyphMap.InitHashTable(253); }	19 CFX_SizeGlyphCache() { m_GlyphMap.InitHashTable(253); }

18 ~CFX_SizeGlyphCache();	20 ~CFX_SizeGlyphCache();

19 CFX_MapPtrToPtr m_GlyphMap;	21 CFX_MapPtrToPtr m_GlyphMap;

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84 FX_DWORD m_Charsets;	86 FX_DWORD m_Charsets;

85 FX_DWORD m_FileSize;	87 FX_DWORD m_FileSize;

86 FX_DWORD m_FontOffset;	88 FX_DWORD m_FontOffset;

87 int m_Weight;	89 int m_Weight;

88 FX_BOOL m_bItalic;	90 FX_BOOL m_bItalic;

89 int m_PitchFamily;	91 int m_PitchFamily;

90 CFX_ByteString m_FontTables;	92 CFX_ByteString m_FontTables;

91 };	93 };

92	94

93 #endif // CORE_SRC_FXGE_GE_TEXT_INT_H_	95 #endif // CORE_SRC_FXGE_GE_TEXT_INT_H_

OLD	NEW

« no previous file with comments | « core/src/fxge/ge/fx_ge_fontmap.cpp ('k') | fpdfsdk/include/fsdk_define.h » ('j') | no next file with comments »