core/src/fxge/ge/fx_ge_font.cpp - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/ge/fx_ge_font.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/ge/fx_ge_font.cpp

diff --git a/core/src/fxge/ge/fx_ge_font.cpp b/core/src/fxge/ge/fx_ge_font.cpp

index d729d2ac1dcd3486187db84e0e25649952c44d41..f739409d7661efb732ca7f7d801899682dcba9dc 100644

--- a/core/src/fxge/ge/fx_ge_font.cpp

+++ b/core/src/fxge/ge/fx_ge_font.cpp

@@ -8,9 +8,6 @@

#include "../../../include/fxge/fx_freetype.h"

#include "text_int.h"

#define EM_ADJUST(em, a) (em == 0 ? (a) : (a)*1000 / em)

-extern void _FPDFAPI_GetInternalFontData(int id1,

- const uint8_t*& data,

- FX_DWORD& size);

CFX_Font::CFX_Font() {

m_pSubstFont = NULL;

m_Face = NULL;

« no previous file with comments | « core/src/fxge/dib/fx_dib_transform.cpp ('k') | core/src/fxge/ge/fx_ge_fontmap.cpp » ('j') | no next file with comments »