core/include/fxge/fx_font.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/include/fxge/fx_font.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Stray file. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_INCLUDE_FXGE_FX_FONT_H_	7 #ifndef CORE_INCLUDE_FXGE_FX_FONT_H_

8 #define CORE_INCLUDE_FXGE_FX_FONT_H_	8 #define CORE_INCLUDE_FXGE_FX_FONT_H_

9	9

10 #include <map>	10 #include <map>

(...skipping 418 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
429	429

430 class IFX_GSUBTable {	430 class IFX_GSUBTable {

431 public:	431 public:

432 static IFX_GSUBTable* Create(CFX_Font* pFont);	432 static IFX_GSUBTable* Create(CFX_Font* pFont);

433 virtual FX_BOOL GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum) = 0;	433 virtual FX_BOOL GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum) = 0;

434	434

435 protected:	435 protected:

436 virtual ~IFX_GSUBTable() {}	436 virtual ~IFX_GSUBTable() {}

437 };	437 };

438	438

	439 CFX_ByteString FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name);
	Lei Zhang 2015/08/19 19:31:14 FPDF_Foo() is usually a public API. Omit the "FPDF FPDF_Foo() is usually a public API. Omit the "FPDF_" ? Tom Sepez 2015/08/19 20:25:34 Done. https://code.google.com/p/chromium/codesear Show quoted text On 2015/08/19 19:31:14, Lei Zhang wrote: > FPDF_Foo() is usually a public API. Omit the "FPDF_" ? Done. https://code.google.com/p/chromium/codesearch#search/&q=file:third_party/pdfi... shows a few more to clean up if we believe this. Plus functions local to a .cpp. Plus _FPDF_. ... would make a nice followup.
	440

439 #endif // CORE_INCLUDE_FXGE_FX_FONT_H_	441 #endif // CORE_INCLUDE_FXGE_FX_FONT_H_

OLD	NEW

« no previous file with comments | « core/include/fpdfapi/fpdf_render.h ('k') | core/src/fpdfapi/fpdf_cmaps/cmap_int.h » ('j') | core/src/fpdftext/text_int.h » ('J')