Extern in .cpp file is a code smell, part 2.

core/src/fpdftext/fpdf_text_search.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfapi/fpdf_pageobj.h"
 #include "../../include/fpdfapi/fpdf_page.h"
+#include "text_int.h"
+
 class CPDF_TextStream {
  public:
   CPDF_TextStream(CFX_WideTextBuf& buffer,
                   FX_BOOL bUseLF,
                   CFX_PtrArray* pObjArray);
   ~CPDF_TextStream() {}
   FX_BOOL ProcessObject(const CPDF_TextObject* pObj, FX_BOOL bFirstLine);
   CFX_WideTextBuf& m_Buffer;
   FX_BOOL m_bUseLF;
   CFX_PtrArray* m_pObjArray;
@@ skipping 267 matching lines @@
       if (m_pObjArray) {
         for (int i = 0; i < unicode_str.GetLength(); i++) {
           m_pObjArray->Add((void*)pObj);
           m_pObjArray->Add((void*)(intptr_t)item_index);
         }
       }
     }
   }
   return FALSE;
 }
-void _PDF_GetTextStream_Unicode(CFX_WideTextBuf& buffer,
-                                CPDF_PageObjects* pPage,
-                                FX_BOOL bUseLF,
-                                CFX_PtrArray* pObjArray) {
+void GetTextStream_Unicode(CFX_WideTextBuf& buffer,
+                           CPDF_PageObjects* pPage,
+                           FX_BOOL bUseLF,
+                           CFX_PtrArray* pObjArray) {
   CPDF_TextStream textstream(buffer, bUseLF, pObjArray);
   FX_POSITION pos = pPage->GetFirstObjectPosition();
   while (pos) {
     CPDF_PageObject* pObject = pPage->GetNextObject(pos);
     if (pObject == NULL) {
       continue;
     }
     if (pObject->m_Type != PDFPAGE_TEXT) {
       continue;
     }
@@ skipping 16 matching lines @@
     CPDF_PageObject* pObject = page.GetNextObject(pos);
     if (pObject->m_Type != PDFPAGE_TEXT) {
       continue;
     }
     if (textstream.ProcessObject((CPDF_TextObject*)pObject, TRUE)) {
       break;
     }
   }
   return buffer.GetWideString();
 }