Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fpdfapi/fpdf_parser.h" 7 #include "../../../include/fpdfapi/fpdf_parser.h"
8 #include "../../../include/fxcrt/fx_string.h" 8 #include "../../../include/fxcrt/fx_string.h"
9 9
10 // static 10 // static
(...skipping 965 matching lines...) Expand 10 before | Expand all | Expand 10 after
976 } 976 }
977 pBuf += actualSize; 977 pBuf += actualSize;
978 size -= actualSize; 978 size -= actualSize;
979 offset += actualSize; 979 offset += actualSize;
980 } 980 }
981 return TRUE; 981 return TRUE;
982 } 982 }
983 return FXSYS_memcmp(m_pDataBuf, pOther->m_pDataBuf, m_dwSize) == 0; 983 return FXSYS_memcmp(m_pDataBuf, pOther->m_pDataBuf, m_dwSize) == 0;
984 } 984 }
985 985
986 extern FX_BOOL PDF_DataDecode(const uint8_t* src_buf,
987 FX_DWORD src_size,
988 const CPDF_Dictionary* pDict,
989 uint8_t*& dest_buf,
990 FX_DWORD& dest_size,
991 CFX_ByteString& ImageEncoding,
992 CPDF_Dictionary*& pImageParms,
993 FX_DWORD estimated_size,
994 FX_BOOL bImageAcc);
995 CPDF_StreamAcc::CPDF_StreamAcc() { 986 CPDF_StreamAcc::CPDF_StreamAcc() {
996 m_bNewBuf = FALSE; 987 m_bNewBuf = FALSE;
997 m_pData = NULL; 988 m_pData = NULL;
998 m_dwSize = 0; 989 m_dwSize = 0;
999 m_pImageParam = NULL; 990 m_pImageParam = NULL;
1000 m_pStream = NULL; 991 m_pStream = NULL;
1001 m_pSrcData = NULL; 992 m_pSrcData = NULL;
1002 } 993 }
1003 void CPDF_StreamAcc::LoadAllData(const CPDF_Stream* pStream, 994 void CPDF_StreamAcc::LoadAllData(const CPDF_Stream* pStream,
1004 FX_BOOL bRawAccess, 995 FX_BOOL bRawAccess,
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 } 1197 }
1207 pObj->m_ObjNum = objnum; 1198 pObj->m_ObjNum = objnum;
1208 m_IndirectObjs.SetAt((void*)(uintptr_t)objnum, pObj); 1199 m_IndirectObjs.SetAt((void*)(uintptr_t)objnum, pObj);
1209 if (m_LastObjNum < objnum) { 1200 if (m_LastObjNum < objnum) {
1210 m_LastObjNum = objnum; 1201 m_LastObjNum = objnum;
1211 } 1202 }
1212 } 1203 }
1213 FX_DWORD CPDF_IndirectObjects::GetLastObjNum() const { 1204 FX_DWORD CPDF_IndirectObjects::GetLastObjNum() const {
1214 return m_LastObjNum; 1205 return m_LastObjNum;
1215 } 1206 }
OLDNEW
« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp ('k') | core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698