core/src/fpdfapi/fpdf_font/fpdf_font.cpp - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

index a228cf76ec2b687c54b3d6d2ede3a0965e4f9cb5..20c4082d4a6f36ed7792bfa398dd0d8777e5dcc1 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

@@ -1041,7 +1041,6 @@ static FX_BOOL FT_UseType1Charmap(FXFT_Face face) {

}

return TRUE;

}

-extern FX_WCHAR FT_UnicodeFromCharCode(int encoding, FX_DWORD charcode);

#if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_

#include "../../fxge/apple/apple_int.h"

#endif