Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp ('k') | core/src/fpdfdoc/doc_ap.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fxge/fx_ge.h" 7 #include "../../../include/fxge/fx_ge.h"
8 #include "../../../include/fpdfapi/fpdf_render.h" 8 #include "../../../include/fpdfapi/fpdf_render.h"
9 #include "../../../include/fpdfapi/fpdf_pageobj.h" 9 #include "../../../include/fpdfapi/fpdf_pageobj.h"
10 #include "../fpdf_page/pageint.h" 10 #include "../fpdf_page/pageint.h"
11 #include "render_int.h" 11 #include "render_int.h"
12 extern FX_BOOL IsAvailableMatrix(const CFX_AffineMatrix& matrix); 12
13 CPDF_Type3Cache::~CPDF_Type3Cache() { 13 CPDF_Type3Cache::~CPDF_Type3Cache() {
14 for (const auto& pair : m_SizeMap) { 14 for (const auto& pair : m_SizeMap) {
15 delete pair.second; 15 delete pair.second;
16 } 16 }
17 m_SizeMap.clear(); 17 m_SizeMap.clear();
18 } 18 }
19 CFX_GlyphBitmap* CPDF_Type3Cache::LoadGlyph(FX_DWORD charcode, 19 CFX_GlyphBitmap* CPDF_Type3Cache::LoadGlyph(FX_DWORD charcode,
20 const CFX_AffineMatrix* pMatrix, 20 const CFX_AffineMatrix* pMatrix,
21 FX_FLOAT retinaScaleX, 21 FX_FLOAT retinaScaleX,
22 FX_FLOAT retinaScaleY) { 22 FX_FLOAT retinaScaleY) {
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 ProcessPath(&path, pObj2Device); 788 ProcessPath(&path, pObj2Device);
789 } 789 }
790 } 790 }
791 791
792 CFX_PathData* CPDF_Font::LoadGlyphPath(FX_DWORD charcode, int dest_width) { 792 CFX_PathData* CPDF_Font::LoadGlyphPath(FX_DWORD charcode, int dest_width) {
793 int glyph_index = GlyphFromCharCode(charcode); 793 int glyph_index = GlyphFromCharCode(charcode);
794 if (!m_Font.GetFace()) 794 if (!m_Font.GetFace())
795 return nullptr; 795 return nullptr;
796 return m_Font.LoadGlyphPath(glyph_index, dest_width); 796 return m_Font.LoadGlyphPath(glyph_index, dest_width);
797 } 797 }
OLDNEW
« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp ('k') | core/src/fpdfdoc/doc_ap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698