fpdfsdk/src/fpdf_dataavail.cpp - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_dataavail.cpp

diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp

index dddf9afb08828ce49f0404f7d37b16da025ff9d5..9ce298d0c545256d7c5abda89d8d31c660a9b05d 100644

--- a/fpdfsdk/src/fpdf_dataavail.cpp

+++ b/fpdfsdk/src/fpdf_dataavail.cpp

@@ -7,7 +7,6 @@

#include "../../public/fpdf_dataavail.h"

#include "../include/fsdk_define.h"

-extern void ProcessParseError(FX_DWORD err_code);

class CFPDF_FileAvailWrap : public IFX_FileAvail {

public:

CFPDF_FileAvailWrap() { m_pfileAvail = NULL; }

« no previous file with comments | « fpdfsdk/include/fxedit/fx_edit.h ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »