Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fpdfapi/fpdf_module.h" 7 #include "../../../include/fpdfapi/fpdf_module.h"
8 #include "../../../include/fpdfapi/fpdf_page.h" 8 #include "../../../include/fpdfapi/fpdf_page.h"
9 #include "../../../include/fpdfapi/fpdf_pageobj.h" 9 #include "../../../include/fpdfapi/fpdf_pageobj.h"
10 #include "../../../include/fpdfapi/fpdf_resource.h" 10 #include "../../../include/fpdfapi/fpdf_resource.h"
(...skipping 1023 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 return FALSE; 1034 return FALSE;
1035 } 1035 }
1036 if (FXFT_Get_Charmap_Encoding(FXFT_Get_Face_Charmaps(face)[0]) == 1036 if (FXFT_Get_Charmap_Encoding(FXFT_Get_Face_Charmaps(face)[0]) ==
1037 FXFT_ENCODING_UNICODE) { 1037 FXFT_ENCODING_UNICODE) {
1038 FXFT_Set_Charmap(face, FXFT_Get_Face_Charmaps(face)[1]); 1038 FXFT_Set_Charmap(face, FXFT_Get_Face_Charmaps(face)[1]);
1039 } else { 1039 } else {
1040 FXFT_Set_Charmap(face, FXFT_Get_Face_Charmaps(face)[0]); 1040 FXFT_Set_Charmap(face, FXFT_Get_Face_Charmaps(face)[0]);
1041 } 1041 }
1042 return TRUE; 1042 return TRUE;
1043 } 1043 }
1044 extern FX_WCHAR FT_UnicodeFromCharCode(int encoding, FX_DWORD charcode);
1045 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ 1044 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
1046 #include "../../fxge/apple/apple_int.h" 1045 #include "../../fxge/apple/apple_int.h"
1047 #endif 1046 #endif
1048 int CPDF_Type1Font::GlyphFromCharCodeExt(FX_DWORD charcode) { 1047 int CPDF_Type1Font::GlyphFromCharCodeExt(FX_DWORD charcode) {
1049 if (charcode > 0xff) { 1048 if (charcode > 0xff) {
1050 return -1; 1049 return -1;
1051 } 1050 }
1052 int index = m_ExtGID[(uint8_t)charcode]; 1051 int index = m_ExtGID[(uint8_t)charcode];
1053 if (index == 0xffff) { 1052 if (index == 0xffff) {
1054 return -1; 1053 return -1;
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1781 CPDF_Type3Char::CPDF_Type3Char() { 1780 CPDF_Type3Char::CPDF_Type3Char() {
1782 m_pForm = NULL; 1781 m_pForm = NULL;
1783 m_pBitmap = NULL; 1782 m_pBitmap = NULL;
1784 m_bPageRequired = FALSE; 1783 m_bPageRequired = FALSE;
1785 m_bColored = FALSE; 1784 m_bColored = FALSE;
1786 } 1785 }
1787 CPDF_Type3Char::~CPDF_Type3Char() { 1786 CPDF_Type3Char::~CPDF_Type3Char() {
1788 delete m_pForm; 1787 delete m_pForm;
1789 delete m_pBitmap; 1788 delete m_pBitmap;
1790 } 1789 }
OLDNEW
« no previous file with comments | « core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp ('k') | core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698