fpdfsdk/include/fsdk_define.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/include/fsdk_define.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef FPDFSDK_INCLUDE_FSDK_DEFINE_H_	7 #ifndef FPDFSDK_INCLUDE_FSDK_DEFINE_H_

8 #define FPDFSDK_INCLUDE_FSDK_DEFINE_H_	8 #define FPDFSDK_INCLUDE_FSDK_DEFINE_H_

9	9

10 #include "../../core/include/fpdfapi/fpdf_module.h"	10 #include "../../core/include/fpdfapi/fpdf_module.h"

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 int start_y,	67 int start_y,

68 int size_x,	68 int size_x,

69 int size_y,	69 int size_y,

70 int rotate,	70 int rotate,

71 int flags,	71 int flags,

72 FX_BOOL bNeedToRestore,	72 FX_BOOL bNeedToRestore,

73 IFSDK_PAUSE_Adapter* pause);	73 IFSDK_PAUSE_Adapter* pause);

74	74

75 void CheckUnSupportError(CPDF_Document* pDoc, FX_DWORD err_code);	75 void CheckUnSupportError(CPDF_Document* pDoc, FX_DWORD err_code);

76 void CheckUnSupportAnnot(CPDF_Document* pDoc, CPDF_Annot* pPDFAnnot);	76 void CheckUnSupportAnnot(CPDF_Document* pDoc, CPDF_Annot* pPDFAnnot);

	77 void ProcessParseError(FX_DWORD err_code);

77	78

78 #endif // FPDFSDK_INCLUDE_FSDK_DEFINE_H_	79 #endif // FPDFSDK_INCLUDE_FSDK_DEFINE_H_

OLD	NEW

« no previous file with comments | « core/src/fxge/ge/text_int.h ('k') | fpdfsdk/include/fxedit/fx_edit.h » ('j') | no next file with comments »