Fix some case-insensitive cases for StartsWith

Fix some case-insensitive cases for StartsWith.

This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure).

The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString

Add a missing protobuf dependency in components/storage_monitor that a try run turned up.

In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc,

In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal.

BUG=506255
Committed: https://crrev.com/94a2cc2c77b73aaaceae5de709c6b453f8fe2c0e
Cr-Commit-Position: refs/heads/master@{#337093}

[brettw, 2015-06-29 06:03:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-29 06:03:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/60001

[commit-bot: I haz the power, 2015-06-29 06:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 06:22:27]

Dry run: Exceeded global retry quota

[brettw, 2015-06-30 23:41:06]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2015-06-30 23:41:07]

Please review carefully, don't rubberstamp. Sorry

[brettw, 2015-06-30 23:41:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-30 23:42:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/120001

[commit-bot: I haz the power, 2015-07-01 00:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 00:07:33]

Dry run: Exceeded global retry quota

[sky, 2015-07-01 03:18:28]

https://codereview.chromium.org/1220653002/diff/120001/chrome/common/variatio...
File chrome/common/variations/experiment_labels.cc (right):

https://codereview.chromium.org/1220653002/diff/120001/chrome/common/variatio...
chrome/common/variations/experiment_labels.cc:100:
DCHECK(!base::StartsWith(variation_labels, separator,
I'm not familiar with this code. How come it's ok to go from insensitive to
sensitive?

https://codereview.chromium.org/1220653002/diff/120001/net/base/net_util.cc
File net/base/net_util.cc (right):

https://codereview.chromium.org/1220653002/diff/120001/net/base/net_util.cc#n...
net/base/net_util.cc:282: return base::StartsWith(text, www,
base::CompareCase::INSENSITIVE_ASCII)
It seems right that this code is insensitive, yet previously it was sensitive.
Is this an ok change? Meaning I'm not familiar with what callers of this expect.

[vabr (Chromium), 2015-07-01 09:22:03]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-07-01 09:22:04]

FWIW, components/autofill/content/renderer/password_autofill_agent.cc,
components/autofill/content/renderer/password_form_conversion_utils.cc and
components/password_manager/core/browser/password_autofill_manager.cc LGTM.

Is there a bug tracking these changes? I could not find a reference in the CL
summary.

Thanks!
Vaclav

[brettw, 2015-07-01 16:54:26]

brettw@chromium.org changed reviewers:
+ grt@chromium.org

[brettw, 2015-07-01 16:54:27]

+grt for chrome/installer.

I filed a bug for this work

https://codereview.chromium.org/1220653002/diff/120001/chrome/common/variatio...
File chrome/common/variations/experiment_labels.cc (right):

https://codereview.chromium.org/1220653002/diff/120001/chrome/common/variatio...
chrome/common/variations/experiment_labels.cc:100:
DCHECK(!base::StartsWith(variation_labels, separator,
On 2015/07/01 03:18:27, sky wrote:
> I'm not familiar with this code. How come it's ok to go from insensitive to
> sensitive?

The separator is a semicolon.

https://codereview.chromium.org/1220653002/diff/120001/net/base/net_util.cc
File net/base/net_util.cc (right):

https://codereview.chromium.org/1220653002/diff/120001/net/base/net_util.cc#n...
net/base/net_util.cc:282: return base::StartsWith(text, www,
base::CompareCase::INSENSITIVE_ASCII)
This was a mistake, I didn't mean to change it. I fixed it.

If it's dealing with normal host names, they'll already be lower-cased so the
existing code doesn't jump out as necessarily wrong to me.

[brettw, 2015-07-01 16:55:38]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-01 16:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1220653002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-07-01 16:56:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/140001

[commit-bot: I haz the power, 2015-07-01 17:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 17:11:36]

Dry run: Exceeded global retry quota

[brettw, 2015-07-01 17:24:24]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-01 17:24:25]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1220653002/#ps160001
(title: "Mac fix")

[commit-bot: I haz the power, 2015-07-01 17:24:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/160001

[sky, 2015-07-01 17:25:23]

LGTM

[commit-bot: I haz the power, 2015-07-01 17:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 17:49:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[grt (UTC plus 2), 2015-07-01 17:55:42]

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/gcapi...
File chrome/installer/gcapi/gcapi_omaha_experiment.cc (right):

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/gcapi...
chrome/installer/gcapi/gcapi_omaha_experiment.cc:53: !base::StartsWith(entry,
label + L"=", base::CompareCase::SENSITIVE)) {
wdyt of pulling "const base::string16 label_and_separator(label + L"=");" out of
the loop and using label_and_separator here?

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
File chrome/installer/util/delete_after_reboot_helper.cc (right):

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
chrome/installer/util/delete_after_reboot_helper.cc:332: base::string16
prefix(L"\\??\\");
nit: base::StringPiece16 prefix(L"\\??\\"); to avoid a memcpy.

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
chrome/installer/util/delete_after_reboot_helper.cc:334: match_path =
match_path.substr(4);
nit: 4 -> prefix.size()

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
chrome/installer/util/delete_after_reboot_helper.cc:343: DWORD prefix_len =
static_cast<DWORD>(short_form_needle.value().size());
base::saturated_cast<DWORD, size_t>()?

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
File chrome/installer/util/install_util.cc (right):

https://codereview.chromium.org/1220653002/diff/160001/chrome/installer/util/...
chrome/installer/util/install_util.cc:401: DWORD prefix_len =
static_cast<DWORD>(program_files_path.value().size());
base::saturated_cast<DWORD, size_t>()?

[brettw, 2015-07-01 18:17:42]

grt: New patch up with comments addressed.

[brettw, 2015-07-01 18:17:49]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-01 18:17:49]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1220653002/#ps180001
(title: "grt's review comments, Mac fix")

[commit-bot: I haz the power, 2015-07-01 18:17:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/180001

[grt (UTC plus 2), 2015-07-01 18:29:37]

chrome/installer lgtm

[brettw, 2015-07-01 18:58:05]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-07-01 18:58:13]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-01 19:00:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220653002/180001

[commit-bot: I haz the power, 2015-07-01 19:27:02]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-07-01 19:29:10]

Patchset 10 (id:??) landed as
https://crrev.com/94a2cc2c77b73aaaceae5de709c6b453f8fe2c0e
Cr-Commit-Position: refs/heads/master@{#337093}