|
Fix some case-insensitive cases for StartsWith.
This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure).
The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString
Add a missing protobuf dependency in components/storage_monitor that a try run turned up.
In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc,
In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal.
BUG= 506255
Committed: https://crrev.com/94a2cc2c77b73aaaceae5de709c6b453f8fe2c0e
Cr-Commit-Position: refs/heads/master@{#337093}
Total comments: 4
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+185 lines, -89 lines) |
Patch |
 |
M |
chrome/browser/enumerate_modules_model_win.cc
|
View
|
1
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/common/variations/experiment_labels.cc
|
View
|
1
|
2 chunks |
+18 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/installer/gcapi/gcapi_omaha_experiment.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+7 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/installer/util/delete_after_reboot_helper.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+15 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/installer/util/install_util.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+12 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/installer/util/shell_util_unittest.cc
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/browser/wallet/wallet_service_url.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/BUILD.gn
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/autofill_agent.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/password_autofill_agent.cc
|
View
|
1
2
|
3 chunks |
+13 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/password_form_conversion_utils.cc
|
View
|
1
2
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/personal_data_manager.cc
|
View
|
1
2
|
4 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_utils.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/browser_watcher/exit_code_watcher_win_unittest.cc
|
View
|
1
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/omnibox/answers_cache.cc
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/omnibox/base_search_provider.cc
|
View
|
1
2
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/omnibox/search_suggestion_parser.cc
|
View
|
1
2
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/omnibox/suggestion_answer.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/omnibox/url_prefix.cc
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/password_autofill_manager.cc
|
View
|
1
2
|
4 chunks |
+11 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/policy/core/common/preg_parser_win.cc
|
View
|
1
2
3
4
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/search_engines/template_url_service_util_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/storage_monitor/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/storage_monitor/portable_device_watcher_win.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/loader/resource_dispatcher_host_browsertest.cc
|
View
|
1
|
4 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/common/plugin_list_mac.mm
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
extensions/common/extension_urls.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/base/net_util.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/base/net_util_icu.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/ftp/ftp_directory_listing_parser_netware.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/ftp/ftp_directory_listing_parser_vms.cc
|
View
|
1
2
3
4
5
|
3 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 37 (17 generated)
|