Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 79542aff2520a500debcf60c29699d73e28d5524..d1ea08856d48c2791e0421e916b8050889c43f48 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -7,6 +7,7 @@
#include "base/auto_reset.h"
#include "base/bind.h"
#include "base/command_line.h"
+#include "base/i18n/case_conversion.h"
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_split.h"
@@ -87,18 +88,21 @@ void GetDataListSuggestions(const WebInputElement& element,
if (!ignore_current_value) {
prefix = element.editingValue();
if (element.isMultiple() && element.isEmailField()) {
- std::vector<base::string16> parts;
- base::SplitStringDontTrim(prefix, ',', &parts);
+ const base::char16 comma[2] = { ',', 0 };
+ std::vector<base::string16> parts = base::SplitString(
+ prefix, comma, base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
if (parts.size() > 0) {
base::TrimWhitespace(parts[parts.size() - 1], base::TRIM_LEADING,
&prefix);
}
}
}
+ prefix = base::i18n::ToLower(prefix);
for (WebOptionElement option = options.firstItem().to<WebOptionElement>();
!option.isNull(); option = options.nextItem().to<WebOptionElement>()) {
- if (!base::StartsWith(option.value(), prefix, false) ||
- option.value() == prefix || !element.isValidValue(option.value()))
+ if (!base::StartsWith(base::i18n::ToLower(base::string16(option.value())),
+ prefix, base::CompareCase::SENSITIVE) ||
+ !element.isValidValue(option.value()))
continue;
values->push_back(option.value());
« no previous file with comments | « components/autofill/content/renderer/BUILD.gn ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698