Fix some case-insensitive cases for StartsWith

content/common/plugin_list_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/plugin_list.h"
 
 #import <Carbon/Carbon.h>
 #import <Foundation/Foundation.h>
 
 #include "base/files/file_enumerator.h"
@@ skipping 29 matching lines @@
 
   plugin_dirs->push_back(base::FilePath(base::mac::PathFromFSRef(ref)));
 }
 
 // Returns true if the plugin should be prevented from loading.
 bool IsBlacklistedPlugin(const WebPluginInfo& info) {
   // We blacklist Gears by included MIME type, since that is more stable than
   // its name. Be careful about adding any more plugins to this list though,
   // since it's easy to accidentally blacklist plugins that support lots of
   // MIME types.
-  for (std::vector<WebPluginMimeType>::const_iterator i =
-           info.mime_types.begin(); i != info.mime_types.end(); ++i) {
+  for (const WebPluginMimeType& mime : info.mime_types) {
     // The Gears plugin is Safari-specific, so don't load it.
-    if (i->mime_type == "application/x-googlegears")
+    if (mime.mime_type == "application/x-googlegears")
       return true;
   }
 
   // Versions of Flip4Mac 2.3 before 2.3.6 often hang the renderer, so don't
   // load them.
-  if (base::StartsWith(info.name, base::ASCIIToUTF16("Flip4Mac Windows Media"),
-                       false) &&
-      base::StartsWith(info.version, base::ASCIIToUTF16("2.3"), false)) {
-    std::vector<base::string16> components;
-    base::SplitString(info.version, '.', &components);
+  if (base::StartsWith(info.name,
+                       base::ASCIIToUTF16("Flip4Mac Windows Media"),
+                       base::CompareCase::INSENSITIVE_ASCII) &&
+      base::StartsWith(info.version, base::ASCIIToUTF16("2.3"),
+                       base::CompareCase::SENSITIVE)) {
+    std::vector<base::StringPiece16> components = base::SplitStringPiece(
+        info.version, base::ASCIIToUTF16("."), base::TRIM_WHITESPACE,
+        base::SPLIT_WANT_ALL);
     int bugfix_version = 0;
     return (components.size() >= 3 &&
             base::StringToInt(components[2], &bugfix_version) &&
             bugfix_version < 6);
   }
 
   return false;
 }
 
 NSDictionary* GetMIMETypes(CFBundleRef bundle) {
@@ skipping 63 matching lines @@
 
     // Skip any disabled types.
     if (type_enabled && ![type_enabled boolValue])
       continue;
 
     WebPluginMimeType mime;
     mime.mime_type = base::SysNSStringToUTF8([mime_type lowercaseString]);
     // Remove PDF from the list of types handled by QuickTime, since it provides
     // a worse experience than just downloading the PDF.
     if (mime.mime_type == "application/pdf" &&
-        base::StartsWithASCII(filename.BaseName().value(), "QuickTime",
-                              false)) {
+        base::StartsWith(filename.BaseName().value(), "QuickTime",
+                         base::CompareCase::INSENSITIVE_ASCII)) {
       continue;
     }
 
     if (mime_desc)
       mime.description = base::SysNSStringToUTF16(mime_desc);
     for (NSString* ext in mime_exts)
       mime.file_extensions.push_back(
           base::SysNSStringToUTF8([ext lowercaseString]));
 
     info->mime_types.push_back(mime);
@@ skipping 137 matching lines @@
   }
 }
 
 bool PluginList::ShouldLoadPluginUsingPluginList(
     const WebPluginInfo& info,
     std::vector<WebPluginInfo>* plugins) {
   return !IsBlacklistedPlugin(info);
 }
 
 }  // namespace content