Update base::StartsWith calls to new form

Update base::StartsWith calls to new form.

The new form takes an case-sensitivity enum rather than a bool. This maps
 true -> base::CompareCase::SENSITIVE
 false with punctuation only -> base::CompareCase::SENSITIVE
 false with ascii constants -> base::CompareCase::INSENSITIVE_ASCII
 false with arbitrary string16 -> base::CompareCase::SENSITIVE with base::i18n::ToLower() on the arguments.

This also updates a few SplitString calls to the new form that I encountered along the way.

BUG=506920, 506255
Committed: https://crrev.com/c7a4cf4382ded31385f8430fd5c664abca480214
Cr-Commit-Position: refs/heads/master@{#337442}

[brettw, 2015-07-01 22:28:54]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-01 22:30:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220963005/20001

[commit-bot: I haz the power, 2015-07-01 22:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 22:54:03]

Dry run: Exceeded global retry quota

[brettw, 2015-07-02 16:55:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-02 16:55:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220963005/40001

[commit-bot: I haz the power, 2015-07-02 17:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 17:58:55]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-06 17:13:07]

brettw@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-06 17:55:01]

lgtm(SENSIBLE_CL)

I stopped checking if the existing code makes sense relatively soon (several
places think that urls and mime types should be cases sensitive) and only
checked that before and after have the same behavior. I commented about the
tolower thing not being 100% correct on your other cl that added the comment
recommending it.

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/autofill...
File chrome/browser/autofill/autofill_browsertest.cc (right):

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/autofill...
chrome/browser/autofill/autofill_browsertest.cc:253: lines[i], "|",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
this is unrelated?

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_util.cc (left):

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_util.cc:432: return
base::StartsWithASCII(input_method_id, "xkb:", false) ||
why was comparing with "xkb:" a case-sensitive comparison in the previous file
but is case-insensitive here? that looks strange. (predates this cl though)

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(left):

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:380: if
(base::StartsWithASCII(name(), "systemIndicator.", false)) {
(this looks strange too. asked the original authors about this here:
https://chromiumcodereview.appspot.com/11361189/#msg38)

https://codereview.chromium.org/1220963005/diff/40001/chrome/utility/importer...
File chrome/utility/importer/bookmark_html_reader.cc (left):

https://codereview.chromium.org/1220963005/diff/40001/chrome/utility/importer...
chrome/utility/importer/bookmark_html_reader.cc:305: if
(!base::StartsWithASCII(line, kFolderOpen, true))
sure, let's treat tags as case-sensitive starting halfway down this file!

https://codereview.chromium.org/1220963005/diff/40001/chrome/utility/importer...
chrome/utility/importer/bookmark_html_reader.cc:440: if
(!base::StartsWithASCII(line, kItemOpen, false))
…or don't! I guess <DT><A is different from <DT><A further up.

[brettw, 2015-07-06 18:21:31]

I have not been putting any thought into what the callers actually want and have
been focusing only on not breaking things any more than before. It was
immediately obvious on starting this that current usage is not correct at all
and that in a lot of places people use "false" as some kind of "default
behavior" which they probably meant to be base-sensitive instead.

[brettw, 2015-07-06 18:23:35]

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/autofill...
File chrome/browser/autofill/autofill_browsertest.cc (right):

https://codereview.chromium.org/1220963005/diff/40001/chrome/browser/autofill...
chrome/browser/autofill/autofill_browsertest.cc:253: lines[i], "|",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
Oh yeah, I've been doing both SplitString and StartsWith updates, but this patch
got too big so I stopped. It ended up I only changed a few SplitString calls
where I was changing StartsWith already. I added a note to this effect in the CL
description.

[brettw, 2015-07-06 18:24:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-06 18:27:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220963005/40001

[commit-bot: I haz the power, 2015-07-06 19:36:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-06 19:39:22]

Patchset 3 (id:??) landed as
https://crrev.com/c7a4cf4382ded31385f8430fd5c664abca480214
Cr-Commit-Position: refs/heads/master@{#337442}